From cc93236b8edb62303d829d0f260e399e6ab35574 Mon Sep 17 00:00:00 2001
From: Marcel Peterkau <marcel@peterkau.de>
Date: Mon, 11 Dec 2023 19:07:38 +0100
Subject: [PATCH] moved javascript from html file to external script

---
 Software/data_src/index.htm           | 44 ++-------------------------
 Software/data_src/static/js/script.js | 37 ++++++++++++++++++++++
 2 files changed, 39 insertions(+), 42 deletions(-)
 create mode 100644 Software/data_src/static/js/script.js

diff --git a/Software/data_src/index.htm b/Software/data_src/index.htm
index 24b4f28..be46bef 100644
--- a/Software/data_src/index.htm
+++ b/Software/data_src/index.htm
@@ -12,6 +12,7 @@
   <script src="static/js/bootstrap.min.js"></script>
   <script src="static/js/websocket.js"></script>
   <script src="static/js/dtc_table.js"></script>
+  <script src="static/js/script.js" type="text/javascript"></script>
   <link rel="apple-touch-icon" sizes="180x180" href="static/img/apple-touch-icon.png">
   <link rel="icon" type="image/png" sizes="32x32" href="static/img/favicon-32x32.png">
   <link rel="icon" type="image/png" sizes="16x16" href="static/img/favicon-16x16.png">
@@ -791,49 +792,8 @@
 
   <!-- Modal Dialog -->
 
-  <script>
-    $('.navbar-nav>li>a').on('click', function () {
-      $('.navbar-collapse').collapse('hide');
-    });
-
-    document.querySelector('.custom-file-input').addEventListener('change', function (e) {
-      var fileName = document.getElementById("fw-update-file").files[0].name;
-      var nextSibling = e.target.nextElementSibling
-      nextSibling.innerText = fileName
-    });
-
-    $('table').on('click', 'tr[data-dtc]', function () {
-      var dtc = $(this).data('dtc');
-      var debugval = $(this).data('debugval');
-      var modal = $('#dtcModal');
-
-      getDescriptionForDTCNumber(dtc, function (error, title, description) {
-        if (error)
-        {
-          console.error("Fehler beim Abrufen der Beschreibung:", error);
-          modal.find('.modal-title').text("Fehler")
-          modal.find('.dtc-desc').text("DTC-Beschreibung konnte nicht geladen werden")
-        }
-        else
-        {
-          modal.find('.modal-title').text(title)
-          modal.find('.dtc-desc').text(description)
-          if (debugval > 0)
-          {
-            modal.find('.dtc-debugval').text("Debugvalue: " + debugval)
-          }
-          else
-          {
-            modal.find('.dtc-debugval').remove()
-          }
-        }
-      });
-      // Modal anzeigen
-      modal.modal('show');
-    });
-
-  </script>
 
+ 
 </body>
 
 </html>
\ No newline at end of file
diff --git a/Software/data_src/static/js/script.js b/Software/data_src/static/js/script.js
new file mode 100644
index 0000000..eadba67
--- /dev/null
+++ b/Software/data_src/static/js/script.js
@@ -0,0 +1,37 @@
+$(".navbar-nav>li>a").on("click", function () {
+  $(".navbar-collapse").collapse("hide");
+});
+
+document
+  .querySelector(".custom-file-input")
+  .addEventListener("change", function (e) {
+    var fileName = document.getElementById("fw-update-file").files[0].name;
+    var nextSibling = e.target.nextElementSibling;
+    nextSibling.innerText = fileName;
+  });
+
+$("table").on("click", "tr[data-dtc]", function () {
+  var dtc = $(this).data("dtc");
+  var debugval = $(this).data("debugval");
+  var modal = $("#dtcModal");
+
+  getDescriptionForDTCNumber(dtc, function (error, title, description) {
+    if (error) {
+      console.error("Fehler beim Abrufen der Beschreibung:", error);
+      modal.find(".modal-title").text("Fehler");
+      modal
+        .find(".dtc-desc")
+        .text("DTC-Beschreibung konnte nicht geladen werden");
+    } else {
+      modal.find(".modal-title").text(title);
+      modal.find(".dtc-desc").text(description);
+      if (debugval > 0) {
+        modal.find(".dtc-debugval").text("Debugvalue: " + debugval);
+      } else {
+        modal.find(".dtc-debugval").remove();
+      }
+    }
+  });
+  // Modal anzeigen
+  modal.modal("show");
+});